refactor index.js and shared.js #367
Conversation
✅ Deploy Preview for playground-testing ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
Hi @nele-golem, welche linter hast du benutzt? |
|
@egekorkan Ich habe ES-Lint benutzt |
|
I am getting different results on my PC when I run linting. I will try to identify the root of the difference. |
There was a problem hiding this comment.
@nele-golem I think that most of the changes are actually not needed, we do use the commented-out functions. Regarding linting, I am preparing this to be automated. Are there other changes in this PR that I am not seeing?
| "Status": "pass" | ||
| }) | ||
| return results | ||
| // // no security used non defined scheme, passed test |
There was a problem hiding this comment.
this should not be commented out
There was a problem hiding this comment.
hey @egekorkan sry for my late response. MeanwhiIe I changed project, but the linter told me, the code will not be reached, so thats why i commended it out. Which node version do you use? Also it would be great to have the Error Messages also in the Response like "report, details, detailComments". But for now Im fine then! For changes or updated in the future please contact Felix again! Thank you
| @@ -91,9 +94,11 @@ function tdValidator(tdString, logFunc, { checkDefaults=true, checkJsonLd=true } | |||
| } | |||
|
|
|||
| let ajv = new Ajv({strict: false}) // options can be passed, e.g. {allErrors: true} | |||
| ajv = addFormats(ajv) // ajv does not support formats by default anymore | |||
|
|
|||
| // ajv = addFormats(ajv) // ajv does not support formats by default anymore | |||
There was a problem hiding this comment.
this is needed, otherwise warnings are seen like you can see in the current action log
|
@nele-golem I have created #403 . I will close this PR in this case |
Hallo Ege,
für die Nutzung eures Core packages im Editdor, musste ich noch ein paar Kleinigkeiten in der index.js und shared.js anpassen. Teilweise habe ich Sachen auskommentiert, die nicht benutzt wurden und mir Warnungen angezeigt haben oder Linting Fehler angezeigt haben. Eventuell könnt ihr das mal prüfen, damit wir evtl in Zukunft euer Package so einbauen können.
Viele Grüße
Nele