Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to es2021 #1340

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Move to es2021 #1340

merged 2 commits into from
Dec 17, 2024

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Dec 13, 2024

As explained in #1267 we decided to move to a more modern js target. After #1336 everything goes pretty smooth, I'll double check next week if there is anything more to do (or please just comment below if you know more).

Copy link

codecov bot commented Dec 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.37%. Comparing base (38e6abb) to head (6907c75).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1340      +/-   ##
==========================================
- Coverage   77.61%   77.37%   -0.25%     
==========================================
  Files          83       83              
  Lines       16576    16587      +11     
  Branches     1640     1589      -51     
==========================================
- Hits        12866    12834      -32     
- Misses       3652     3729      +77     
+ Partials       58       24      -34     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks everything seems to work 👍

Maybe we can remove the statement here

"target": "ES2018",

as part of this PR

@relu91
Copy link
Member Author

relu91 commented Dec 16, 2024

Should I also update the examples if needed?

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

In a follow-up, we might want to get rid of the whole workflow

### Workflow
1. Run `npm run build`
2. Remove the following 3/4 lines in JS files of folder `dist/`
```
Object.defineProperty(exports, "__esModule", { value: true });
require("wot-typescript-definitions");
let WoT;
let WoTHelpers;
```
3. Copy the according JS file(s) to
- `<node-wot>/examples/scripts`
- `<node-wot>/examples/testthing`

@danielpeintner danielpeintner merged commit d534535 into eclipse-thingweb:master Dec 17, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants