-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move to es2021 #1340
Move to es2021 #1340
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1340 +/- ##
==========================================
- Coverage 77.61% 77.37% -0.25%
==========================================
Files 83 83
Lines 16576 16587 +11
Branches 1640 1589 -51
==========================================
- Hits 12866 12834 -32
- Misses 3652 3729 +77
+ Partials 58 24 -34 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks everything seems to work 👍
Maybe we can remove the statement here
"target": "ES2018", |
as part of this PR
Should I also update the examples if needed? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
In a follow-up, we might want to get rid of the whole workflow
node-wot/packages/examples/README.md
Lines 14 to 29 in 5afa858
### Workflow | |
1. Run `npm run build` | |
2. Remove the following 3/4 lines in JS files of folder `dist/` | |
``` | |
Object.defineProperty(exports, "__esModule", { value: true }); | |
require("wot-typescript-definitions"); | |
let WoT; | |
let WoTHelpers; | |
``` | |
3. Copy the according JS file(s) to | |
- `<node-wot>/examples/scripts` | |
- `<node-wot>/examples/testthing` |
As explained in #1267 we decided to move to a more modern js target. After #1336 everything goes pretty smooth, I'll double check next week if there is anything more to do (or please just comment below if you know more).