Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move to esbuild instead of browserify #1336

Merged
merged 14 commits into from
Dec 13, 2024
Merged

Move to esbuild instead of browserify #1336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
f300c6e
refactor(browser-bundle): move to esbuild
relu91 Aug 2, 2024
2d66e64
chore: introduce test:browser and test:all scripts
relu91 Dec 4, 2024
9cc2015
chore(browser-bundle): add playwright and CI configuration
relu91 Dec 13, 2024
7a1e0ea
ci: upgrade prettier version
relu91 Dec 13, 2024
ba9c2ff
chore(browser-bundle): better format configuration
relu91 Dec 13, 2024
28f1ebe
style: run prettier
relu91 Dec 13, 2024
48ae517
chore: downgrade to prettier 3.0
relu91 Dec 13, 2024
6cb33d5
style: run prettier
relu91 Dec 13, 2024
66baa5d
ci(browser-test): fix branch configuration and minor styling
relu91 Dec 13, 2024
926252c
ci: fix playright configuration and use default container
relu91 Dec 13, 2024
ce327a4
chore: regenarating package-lock
relu91 Dec 13, 2024
f928445
fixup! chore: regenarating package-lock
relu91 Dec 13, 2024
1e26083
ci(browser-test): add linux optional library
relu91 Dec 13, 2024
91f568d
ci(browser-test): add build step
relu91 Dec 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .eslintignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
packages/browser-bundle/web-test-runner.config.mjs
32 changes: 32 additions & 0 deletions .github/workflows/browser-test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
# docs https://playwright.dev/docs/ci-intro#setting-up-github-actions
name: Browser Tests

on:
workflow_dispatch:
push:
branches: [master]
pull_request:
branches: [master]

jobs:
test:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v4
- name: Use Node.js 20.x
uses: actions/setup-node@v4
with:
node-version: 20.x
cache: "npm"
- name: Install Dependencies
run: npm ci
- name: Install linux rollup optional dependencies
run: npm i @rollup/rollup-linux-x64-gnu -D
- name: Install Playwright Browsers
run: npx playwright install --with-deps
- name: Build
run: npm run build
- name: Test with browser bundle
timeout-minutes: 2
run: |
npm run test:browser
2 changes: 1 addition & 1 deletion .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,6 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2
- uses: actionsx/prettier@v2
- uses: actionsx/prettier@v3
with:
args: --check .
2 changes: 1 addition & 1 deletion .husky/pre-push
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

npm test
npm run test
2 changes: 1 addition & 1 deletion examples/browser/counter.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<title>Browser Counter Example</title>
Expand Down
2 changes: 1 addition & 1 deletion examples/browser/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<title>Browser Native node-wot tryout</title>
Expand Down
2 changes: 1 addition & 1 deletion examples/browser/smart-coffee-machine.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<!DOCTYPE html>
<!doctype html>
<html>
<head>
<title>Smart Coffee Machine</title>
Expand Down
Loading
Loading