Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add deprecation message to td-tools #1310

Conversation

danielpeintner
Copy link
Member

@danielpeintner danielpeintner commented Jul 23, 2024

@danielpeintner danielpeintner requested a review from relu91 as a code owner July 23, 2024 08:46
@danielpeintner danielpeintner mentioned this pull request Jul 23, 2024
2 tasks
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about https://github.com/eclipse-thingweb/node-wot/blob/master/packages/td-tools/src/thing-description.ts

It will continue to live in core, right?

Yes, but I would deprecate it and move it (or refactor) in one single PR.

@danielpeintner
Copy link
Member Author

Yes, but I would deprecate it and move it (or refactor) in one single PR.

Shall I deprecate each export like

export default class Thing implements TDT.ThingDescription {

export class Form implements TDT.FormElementBase {

etc in this PR. IF we do so we get warnings everywhere.

OR I would do it once we completely remove the entire td-tools package. That's what I would do.
I hope that matches with you...

@relu91
Copy link
Member

relu91 commented Jul 23, 2024

What I meant was to move on with this PR and in other PR tackle the refactoring of duplicating thing-descriptio.ts to core package and deprecate the code in td-tools package. If we follow this approach we should not get any warning (once all the imports will be updated to use core instead of td-tools).

@danielpeintner danielpeintner merged commit 274bf4a into eclipse-thingweb:master Jul 23, 2024
13 checks passed
JKRhb pushed a commit to JKRhb/thingweb.node-wot that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants