Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: remove unused findProtocol and findPort functions #1308

Merged
merged 4 commits into from
Jul 23, 2024
Merged

refactor: remove unused findProtocol and findPort functions #1308

merged 4 commits into from
Jul 23, 2024

Conversation

hasanheroglu
Copy link
Contributor

@danielpeintner
Copy link
Member

danielpeintner commented Jul 22, 2024 •
edited
Loading

Those functions are exported and we should NOT remove them. The idea is to remove them once we upgrade the version.
see #1301

Hence I propose to deprecate them again.

Note: I am wondering why the CI fails. Are those functions still used? I will re-run the pipeline.. maybe there is another issue...

@relu91 relu91 merged commit 15c5af7 into eclipse-thingweb:master Jul 23, 2024
13 checks passed
@danielpeintner danielpeintner mentioned this pull request Jul 23, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielpeintner danielpeintner danielpeintner approved these changes

@relu91 relu91 relu91 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replacing Protocol and Port Detection
3 participants
@hasanheroglu @danielpeintner @relu91