refactor: update mocha tests with --unhandled-rejections=strict #1300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielpeintner
requested review from
relu91,
JKRhb,
sebastiankb and
egekorkan
as code owners
danielpeintner
commented
Jul 8, 2024
| @@ -887,7 +887,7 @@ class WoTServerTest { | |||
| expect(content.body).not.to.be.undefined; | |||
|
|
|||
| const body = await content.toBuffer(); | |||
| body.should.be.eq('"test"'); | |||
| body.toString().should.be.eq('"newValue"'); | |||
There was a problem hiding this comment.
I assume this is the correct assumption ?
There was a problem hiding this comment.
Yes correct and this was not failing without that option? this is quite bad from mocha side...
There was a problem hiding this comment.
Correct, it was not failing before.
Having said that, since the code is correct, just the test is not correct it is not as bad ...
danielpeintner
commented
Jul 8, 2024
| ).to.eventually.be.rejectedWith(Error); */ | ||
|
|
||
| // TODO need to be fixed, call above works fine, reports true | ||
| // should we really fail if uri Variable is not supported/known? I don't think so... |
There was a problem hiding this comment.
This is the actual question. Shall we really fail?
|
Note: I fixed some easy issues and skipped tests that fail now in
I added information/questions in the commit/changes. Please have a look. |
danielpeintner
commented
Jul 10, 2024
| @@ -28,7 +28,10 @@ const info = createInfoLogger("binding-mqtt", "mqtt-client-subscribe-test.integr | |||
| // should must be called to augment all variables | |||
| should(); | |||
|
|
|||
| describe("MQTT client implementation - integration", () => { | |||
| describe.skip("MQTT client implementation - integration", () => { | |||
There was a problem hiding this comment.
@egekorkan can you check the MQTT tests which I skipped?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1299