-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: report undefined for no expected value() #1230
refactor: report undefined for no expected value() #1230
Conversation
Co-authored-by: Jan Romann <[email protected]>
We have a failing test https://github.com/eclipse-thingweb/node-wot/actions/runs/7889804138/job/21530521048#step:9:198
@relu91 mhh not sure if the test does the correct thing in this case |
I fixed the test by adding a DataSchema which is now required, see 051febc |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1230 +/- ##
==========================================
+ Coverage 77.77% 77.80% +0.03%
==========================================
Files 84 84
Lines 17476 17492 +16
Branches 1770 1773 +3
==========================================
+ Hits 13592 13610 +18
+ Misses 3848 3846 -2
Partials 36 36 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @danielpeintner and sorry for being a little bit stubborn on this issue :)
fixes #1228