Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: enable strict-boolean-expressions globally #1127

Merged
merged 5 commits into from
Oct 21, 2023

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Oct 17, 2023

Depends on #1126, resolves #1046.

@codecov
Copy link

codecov bot commented Oct 17, 2023

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (c14d4dd) 77.17% compared to head (c8b5925) 77.15%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1127      +/-   ##
==========================================
- Coverage   77.17%   77.15%   -0.03%     
==========================================
  Files          80       80              
  Lines       16245    16246       +1     
  Branches     1531     1535       +4     
==========================================
- Hits        12537    12534       -3     
- Misses       3685     3689       +4     
  Partials       23       23              
Files Coverage Δ
packages/binding-netconf/src/netconf.ts 95.12% <100.00%> (+0.25%) ⬆️
packages/binding-opcua/src/factory.ts 100.00% <100.00%> (ø)
packages/binding-file/src/file-client.ts 27.95% <0.00%> (ø)
packages/binding-mbus/src/mbus-client.ts 82.31% <0.00%> (ø)
packages/binding-mbus/src/mbus-connection.ts 70.46% <87.50%> (-0.09%) ⬇️
packages/binding-netconf/src/netconf-client.ts 78.08% <75.00%> (+1.42%) ⬆️
packages/binding-netconf/src/xpath2json.ts 60.92% <66.66%> (-2.14%) ⬇️
packages/binding-modbus/src/modbus-client.ts 86.85% <86.66%> (+0.08%) ⬆️
packages/binding-netconf/src/async-node-netconf.ts 54.43% <20.00%> (-0.33%) ⬇️
packages/binding-mqtt/src/mqtt-broker-server.ts 74.13% <60.00%> (-0.65%) ⬇️
... and 4 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb marked this pull request as ready for review October 17, 2023 16:12
Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a great clean-up! 🎉

packages/cli/src/cli.ts Outdated Show resolved Hide resolved
@JKRhb
Copy link
Member Author

JKRhb commented Oct 19, 2023

(Performed a rebase against master which removed the commit from #1126 from the diff).

@JKRhb
Copy link
Member Author

JKRhb commented Oct 19, 2023

Applied a last tiny improvement in 10f9498 – hopefully, this one is now good to go :)

packages/cli/src/cli.ts Outdated Show resolved Hide resolved
Copy link
Member

@relu91 relu91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good to go 🥳

@relu91 relu91 merged commit 28a084a into eclipse-thingweb:master Oct 21, 2023
11 checks passed
@JKRhb JKRhb deleted the strict-boolean branch October 21, 2023 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Strict boolean expressions
3 participants