-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: enable strict-boolean-expressions globally #1127
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #1127 +/- ##
==========================================
- Coverage 77.17% 77.15% -0.03%
==========================================
Files 80 80
Lines 16245 16246 +1
Branches 1531 1535 +4
==========================================
- Hits 12537 12534 -3
- Misses 3685 3689 +4
Partials 23 23
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's a great clean-up! 🎉
Co-authored-by: Cristiano Aguzzi <[email protected]>
(Performed a rebase against master which removed the commit from #1126 from the diff). |
Applied a last tiny improvement in 10f9498 – hopefully, this one is now good to go :) |
Co-authored-by: Cristiano Aguzzi <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good to go 🥳
Depends on #1126, resolves #1046.