test(binding-coap): await all calls of coapServer.stop()

[JKRhb]

In the context of #1086 and #1077, I noticed that in the CoAP tests, not all invocations of coapServer.stop() are actually explicitly being awaited which might cause the CI to hang if there is an unexpected error.

This PR makes a couple of minor adjustments to improve the cleanup of resources and fix this potential problem (although I am not sure to which extent it is actually a problem to begin).

[codecov]

Codecov Report

Patch and project coverage have no change.

Comparison is base (95ea950) 75.32% compared to head (7a3538a) 75.32%.
Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1094   +/-   ##
=======================================
  Coverage   75.32%   75.32%           
=======================================
  Files          80       80           
  Lines       16057    16057           
  Branches     1503     1503           
=======================================
  Hits        12095    12095           
  Misses       3923     3923           
  Partials       39       39           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[JKRhb]

As I remembered that using both EventEmitter and async can be a bit problematic, I now wrapped the test code in question into Promises, which also had the benefit of slightly better performance, if I am not mistaken :) If your approval stands, then we could merge this one :)

[relu91]

As I remembered that using both EventEmitter and async can be a bit problematic, I now wrapped the test code in question into Promises, which also had the benefit of slightly better performance, if I am not mistaken :) If your approval stands, then we could merge this one :)

Just saw this video yesterday 😄

[JKRhb]

As I remembered that using both EventEmitter and async can be a bit problematic, I now wrapped the test code in question into Promises, which also had the benefit of slightly better performance, if I am not mistaken :) If your approval stands, then we could merge this one :)

Just saw this video yesterday 😄

:D I also had that one in mind ;)