docs(contributing): add a guide for checking of undefined or null
#1093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #1093 +/- ##
==========================================
+ Coverage 75.32% 75.99% +0.66%
==========================================
Files 80 80
Lines 16057 16060 +3
Branches 1503 1627 +124
==========================================
+ Hits 12095 12204 +109
+ Misses 3923 3824 -99
+ Partials 39 32 -7 ☔ View full report in Codecov by Sentry. |
JKRhb
approved these changes
Sep 21, 2023
CONTRIBUTING.md
Outdated
| ``` | ||
|
|
||
| Instead of checking for both null and `undefiend` values (`if(arg !== undefined && arg !== null)`) the preferred solution is to use `!=` or `==` operator. Interestingly in JavaScript | ||
| with ==, null and undefined are only equal to each other. Example: |
There was a problem hiding this comment.
I have issues to understand the part "are only equal to each other".
Don't you want so say the sentence without "only" ?
There was a problem hiding this comment.
Yeah, I think we can remove the only.
…r `null` Co-authored-by: Jan Romann <[email protected]>
relu91
commented
Sep 21, 2023
danielpeintner
approved these changes
Sep 22, 2023
There was a problem hiding this comment.
PR looks good!
I just wonder whether we should wait till we merge since we just checked 2 (out of the many) checkboxes for #1046
|
I'll merge as guide for future PR regarding the issue #1046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following this comment, I thought it would have been good to have some references for future contributors.