-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(coap-server): add support for URI variables #1078
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #1078 +/- ##
==========================================
+ Coverage 75.02% 75.06% +0.03%
==========================================
Files 80 80
Lines 15610 15622 +12
Branches 1499 1498 -1
==========================================
+ Hits 11712 11727 +15
+ Misses 3862 3859 -3
Partials 36 36
☔ View full report in Codecov by Sentry. |
6ef763e
to
3f6f2df
Compare
Thank you for your approval, @egekorkan :) In the last two commits, I applied some additional refactoring/simplification, the functionality itself should remain unchanged, though. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you! Is it okay for you to squash the fixup commits and then merge the PR? Or would you prefer the squash + merge approach (i.e., squashing all commits into one)? |
I would "squash and merge" once we merge the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well Done!
Resolves #1015.