Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: disable Node.js 16 CI builds/tests #1076

Merged
merged 4 commits into from
Sep 12, 2023
Merged

chore: disable Node.js 16 CI builds/tests #1076

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
22f1dd5
chore: disable Node.js 16
danielpeintner Sep 8, 2023
e4129df
chore: update node versions of GitHub workflow also
danielpeintner Sep 8, 2023
10477f5
chore: increase to NPM 9
danielpeintner Sep 11, 2023
a8c1ea4
fix(README): minimum node version
relu91 Sep 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .github/workflows/ci-full.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
os: [macos-latest, ubuntu-latest, windows-latest]
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]

steps:
- name: Checkout
Expand Down Expand Up @@ -38,10 +38,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node.js 16
- name: Use Node.js 18
uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18

- name: Install
run: npm ci
Expand All @@ -54,10 +54,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: install node v16
- name: install node v18
uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18
- name: verify packages version consistency accross sub-modules
run: npm run check:versions

Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ jobs:
strategy:
matrix:
os: [ubuntu-latest]
node-version: [16.x, 18.x, 20.x]
node-version: [18.x, 20.x]

steps:
- name: Checkout
Expand Down Expand Up @@ -38,10 +38,10 @@ jobs:
- name: Checkout
uses: actions/checkout@v2

- name: Use Node.js 16
- name: Use Node.js 18
uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18

- name: Install
run: npm ci
Expand All @@ -54,10 +54,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: install node v16
- name: install node v18
uses: actions/setup-node@v1
with:
node-version: 16
node-version: 18
- name: verify packages version consistency accross sub-modules
run: npm run check:versions

Expand Down
6 changes: 3 additions & 3 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -99,10 +99,10 @@ cs.addCodec(new MyCodec("application/myType"));

### To use with Node.js

> **Warning**: We no longer actively support Node.js version 14 and lower.
> **Warning**: We no longer actively support Node.js version 16 and lower.

- [Node.js](https://nodejs.org/) version 14+
- [npm](https://www.npmjs.com/) version 7+
- [Node.js](https://nodejs.org/) version 16+
relu91 marked this conversation as resolved.
Show resolved Hide resolved
- [npm](https://www.npmjs.com/) version 9+

#### Linux

Expand Down