Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(examples/quickstart/smart-clock): change default port #1075

Merged
merged 1 commit into from
Sep 8, 2023

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Sep 8, 2023

Change to an open port.

@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (c3c468f) 75.02% compared to head (bf874d6) 75.02%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1075   +/-   ##
=======================================
  Coverage   75.02%   75.02%           
=======================================
  Files          80       80           
  Lines       15610    15610           
  Branches     1499     1499           
=======================================
  Hits        11712    11712           
  Misses       3862     3862           
  Partials       36       36           

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Member

@danielpeintner danielpeintner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Usage of the ports should be reflected in https://github.com/eclipse-thingweb/.github/blob/main/PORTS.md

@egekorkan egekorkan merged commit c8177c2 into eclipse-thingweb:master Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants