feat: improve DataSchemaValue handling #86
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR reworks both the internal handling of
DataSchemaValue
s as well as the external API for passing inInteractionInput
s. A potentialInteractionInput
is now more strongly typed and makes it possible to differentiate betweenDataSchemaValue
s andStream
s more reliably. Due to these changes, the behavior of the library should now be more in line with the Scripting API specification which makes a clear distinction here.However, this rework has some side effects: For instance, the new, stricter handling of DataSchemaValues disallows the use of CBOR objects that use non-string-based keys. Morever, it revealed some inconsistencies in the implementation of
ContentCodec
s as well as the validation logic in thevalue()
method of theInteractionOutput
interface. These aspects need to be improved in follow-up PRs.Lastly, to improve code coverage and quality of the library, several additional tests are also included in this PR. Testing is another area that will be improved upon in upcoming PRs.