feat: implement requestThingDescription method #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 52.85% 53.07% +0.22%
==========================================
Files 69 69
Lines 2189 2210 +21
==========================================
+ Hits 1157 1173 +16
- Misses 1032 1037 +5 ☔ View full report in Codecov by Sentry. |
JKRhb
force-pushed
the
request-thing-description
branch
from
0165eca to
b6ae316
Compare
JKRhb
force-pushed
the
request-thing-description
branch
from
b6ae316 to
bc54366
Compare
JKRhb
force-pushed
the
request-thing-description
branch
5 times, most recently
from
b391122 to
2a4c00d
Compare
|
I think this PR is now ready to be merged as an initial implementation :) There is still some work to be done on the binding level and with regard to validation, but as a first step it should be good enough now. |
JKRhb
force-pushed
the
request-thing-description
branch
from
2a4c00d to
e5b5745
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is a first step towards aligning the discovery implementation closer with the Scripting API specification. Based on this PR, it should eventually also be possible to demonstrate some of the open questions I have with regard to covering features like DNS-SD or CoRE RD support from the Discovery Specification.