Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add initial support for server-sent events #200

Merged
merged 2 commits into from
Nov 27, 2024
Merged

feat: add initial support for server-sent events #200

merged 2 commits into from
Nov 27, 2024

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Nov 27, 2024

This PR adds an initial implementation of server-sent events via the sse_channel package to the HTTP binding.

@JKRhb JKRhb force-pushed the sse branch 2 times, most recently from 9c0d6e1 to a20f9c8 Compare November 27, 2024 09:54
@JKRhb JKRhb enabled auto-merge November 27, 2024 09:54
@codecov-commenter
Copy link

codecov-commenter commented Nov 27, 2024

Codecov Report

Attention: Patch coverage is 5.00000% with 19 lines in your changes missing coverage. Please review.

Project coverage is 62.95%. Comparing base (e8373bf) to head (a31de5c).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
lib/src/binding_http/http_subscription.dart 0.00% 17 Missing ⚠️
lib/src/binding_http/http_client.dart 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #200      +/-   ##
==========================================
- Coverage   63.45%   62.95%   -0.50%     
==========================================
  Files          78       79       +1     
  Lines        2301     2319      +18     
==========================================
  Hits         1460     1460              
- Misses        841      859      +18     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb merged commit a5ca0b4 into main Nov 27, 2024
5 checks passed
@JKRhb JKRhb deleted the sse branch November 27, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants