feat(binding_http): add possibility to define a custom SecurityContext #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #194 +/- ##
==========================================
- Coverage 63.69% 63.47% -0.23%
==========================================
Files 78 78
Lines 2292 2300 +8
==========================================
Hits 1460 1460
- Misses 832 840 +8 ☔ View full report in Codecov by Sentry. |
JKRhb
force-pushed
the
http-security-context
branch
from
76363df to
2ab447b
Compare
JKRhb
force-pushed
the
http-security-context
branch
from
2ab447b to
03796d6
Compare
This was referenced Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To be able to add additional trusted certificates to an
HttpClient, this PR adjusts the binding implementation a little to allow for the creation of a custom internalSecurityContext, which can be enhanced with certificates that are included in anHttpClientConfig.