Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve handling of defaults and serialization/deserialization of Thing Descriptions #189

Merged
merged 6 commits into from
Nov 1, 2024

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented Nov 1, 2024

This PR fixes a couple of issues I noticed when it comes to the (de)serialization behavior of Thing Descriptions. It also exposes an unnamed constructor for the ThingDescription class, which can have advantages in certain scenarios in comparison to the deserialization approach (from a Map<String, dynamic>).

As this PR contains some breaking changes, it will trigger the release of version 0.35.0.

@JKRhb JKRhb force-pushed the thing-description-constructor branch 3 times, most recently from 46224d7 to 64048d6 Compare November 1, 2024 10:20
@codecov-commenter
Copy link

codecov-commenter commented Nov 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 63.64%. Comparing base (3765571) to head (e698015).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #189      +/-   ##
==========================================
+ Coverage   63.40%   63.64%   +0.23%     
==========================================
  Files          78       78              
  Lines        2279     2294      +15     
==========================================
+ Hits         1445     1460      +15     
  Misses        834      834              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb force-pushed the thing-description-constructor branch from 64048d6 to 03dcc1e Compare November 1, 2024 10:22
@JKRhb JKRhb force-pushed the thing-description-constructor branch from 2bcb76a to 8d22528 Compare November 1, 2024 10:33
@JKRhb JKRhb force-pushed the thing-description-constructor branch from 8d22528 to e698015 Compare November 1, 2024 10:39
@JKRhb JKRhb marked this pull request as ready for review November 1, 2024 10:40
@JKRhb JKRhb merged commit 252ca33 into main Nov 1, 2024
5 checks passed
@JKRhb JKRhb deleted the thing-description-constructor branch November 1, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants