Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: prevent accidental merge of fixup! commits #127

Merged
merged 1 commit into from
May 17, 2024
Merged

ci: prevent accidental merge of fixup! commits #127

merged 1 commit into from
May 17, 2024

Conversation

JKRhb
Copy link
Member

@JKRhb JKRhb commented May 17, 2024

To prevent the merge of fixup! commits in the future, this PR adds a simple GitHub Actions workflow that exists with an error if there should be any commits on the branch whose message starts with fixup!. The solution is not that ideal yet, but might get improved at a later point in time.

@codecov-commenter
Copy link

codecov-commenter commented May 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.79%. Comparing base (15ea223) to head (9aebe6b).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #127      +/-   ##
==========================================
+ Coverage   65.74%   65.79%   +0.05%     
==========================================
  Files          74       74              
  Lines        2385     2383       -2     
==========================================
  Hits         1568     1568              
+ Misses        817      815       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JKRhb JKRhb marked this pull request as ready for review May 17, 2024 12:58
@JKRhb JKRhb enabled auto-merge May 17, 2024 12:59
@JKRhb JKRhb merged commit 12141d5 into main May 17, 2024
5 checks passed
@JKRhb JKRhb deleted the prevent-fixup branch May 17, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants