Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(otterdog): simplify node-wot protection rules #17

Merged
merged 2 commits into from
Feb 26, 2024

Conversation

relu91
Copy link
Member

@relu91 relu91 commented Feb 24, 2024

As discussed in #16 this PR simplify the protection rules and adds @danielpeintner and me as actors capable of bypassing the rule. I couldn't find a way to define a group (which is more future-proof), but for now, I would say it is sufficient.

@relu91 relu91 requested review from a team as code owners February 24, 2024 10:28
Copy link

This is your friendly self-service bot. The author (relu91) of this PR is associated with this organization in the role of MEMBER.

Additionally, relu91 is a member of the following teams:

This comment has been minimized.

@relu91
Copy link
Member Author

relu91 commented Feb 24, 2024

Ah, I've just noticed that we have github teams in the organization, what should we do? create a iot-thingweb-node-wot-leads group? @egekorkan @danielpeintner @JKRhb

@netomi
Copy link
Contributor

netomi commented Feb 24, 2024

Creating a team and adding people to the team would be better instead of having individuals defined as bypass actors.

If you give me a good team name I can create it and add the members according to your needs. Then we can adjust this PR accordingly.

@netomi
Copy link
Contributor

netomi commented Feb 24, 2024

/validate

Signed-off-by: Thomas Neidhart <[email protected]>
Copy link

This is your friendly self-service bot.
Please find below the validation of the requested configuration changes:

Diff for afff68d
Organization iot.thingweb[id=eclipse-thingweb]
  there have been 1 validation infos, enable verbose output with '-v' to to display them.

  
!   branch_protection_rule[pattern="master", repository="node-wot"] {
!     bypass_pull_request_allowances    = "[]" -> "['@relu91', '@danielpeintner']"
!     required_approving_review_count   = "2" -> "1"
!   }
  
  Plan: 0 to add, 2 to change, 0 to delete.

Add a comment /help to get a list of available commands.

Copy link

This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀

@danielpeintner
Copy link
Member

Creating a team and adding people to the team would be better instead of having individuals defined as bypass actors.

If you give me a good team name I can create it and add the members according to your needs. Then we can adjust this PR accordingly.

Personally I am more in favor of listing individuals.
The list of bypass actors will be very short and different from thingweb project to project. Hence I think adding individuals names is easier to handle instead of coming up with "team names" for each project over an over again. Moreover, this team would solely exist for bypassing PRs.

What do others think?

@netomi
Copy link
Contributor

netomi commented Feb 26, 2024

if you all agree we can then merge the PR as is.

@JKRhb
Copy link
Member

JKRhb commented Feb 26, 2024

Ah, I've just noticed that we have github teams in the organization, what should we do? create a iot-thingweb-node-wot-leads group? @egekorkan @danielpeintner @JKRhb

I guess we could also go for something shorter, like node-wot-leads, right? (As we are now in our own organization?) However, I am also fine with the current approach :)

@netomi netomi merged commit be87699 into eclipse-thingweb:main Feb 26, 2024
3 checks passed
Copy link

This is your friendly self-service bot.

The following changes have been successfully applied:

Organization iot.thingweb[id=eclipse-thingweb]
  there have been 1 validation infos, enable verbose output with '-v' to to display them.

  
!   branch_protection_rule[pattern="master", repository="node-wot"] {
!     bypass_pull_request_allowances    = "[]" -> "['@relu91', '@danielpeintner']"
!     required_approving_review_count   = "2" -> "1"
!   }

  
  Applying changes:


  Done.
  
  Executed plan: 0 added, 2 changed, 0 deleted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants