-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(otterdog): simplify node-wot protection rules #17
Conversation
Signed-off-by: Cristiano Aguzzi <[email protected]>
This comment has been minimized.
This comment has been minimized.
Ah, I've just noticed that we have github teams in the organization, what should we do? create a iot-thingweb-node-wot-leads group? @egekorkan @danielpeintner @JKRhb |
Creating a team and adding people to the team would be better instead of having individuals defined as bypass actors. If you give me a good team name I can create it and add the members according to your needs. Then we can adjust this PR accordingly. |
/validate |
Signed-off-by: Thomas Neidhart <[email protected]>
This is your friendly self-service bot. Diff for afff68dOrganization iot.thingweb[id=eclipse-thingweb]
there have been 1 validation infos, enable verbose output with '-v' to to display them.
! branch_protection_rule[pattern="master", repository="node-wot"] {
! bypass_pull_request_allowances = "[]" -> "['@relu91', '@danielpeintner']"
! required_approving_review_count = "2" -> "1"
! }
Plan: 0 to add, 2 to change, 0 to delete. Add a comment |
This is your friendly self-service bot. The current configuration is in-sync with the live settings. 🚀 |
Personally I am more in favor of listing individuals. What do others think? |
if you all agree we can then merge the PR as is. |
I guess we could also go for something shorter, like |
This is your friendly self-service bot. The following changes have been successfully applied: Organization iot.thingweb[id=eclipse-thingweb]
there have been 1 validation infos, enable verbose output with '-v' to to display them.
! branch_protection_rule[pattern="master", repository="node-wot"] {
! bypass_pull_request_allowances = "[]" -> "['@relu91', '@danielpeintner']"
! required_approving_review_count = "2" -> "1"
! }
Applying changes:
Done.
Executed plan: 0 added, 2 changed, 0 deleted. |
As discussed in #16 this PR simplify the protection rules and adds @danielpeintner and me as actors capable of bypassing the rule. I couldn't find a way to define a group (which is more future-proof), but for now, I would say it is sufficient.