Disable editing of read only variables #14440
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
The debug UI allows to change the variable content. The DAP server provides information if the variable is editable. If the variable is not editable, we disable the functionality in the UI.
How to test
Create a .js file in your workspace and copy the following code:
Set the breakpoint on the line
test()
Launch debugging of the current file
Inspect Local variable "test" and it's children. When right clicking on arguments, the "Set Value" option should be disabled. Double clicking on the variable should not open the editing dialog.
Review checklist
Reminder for reviewers