upgraded node pty #14342
Draft
upgraded node pty #14342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonah Iden <[email protected]>
|
@jonah-iden See #13614 (comment) for a bit of context on the failing tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
It seems there were some problems with the spawn helper of node pty on some linux based systems which led to the theia backend being frozen. They removed the spawn helpder in 1.0.0 so this should (hopefully) fix this issue. I sadly couldn't reproduce the issue myself.
I tested terminals on windows and on linux (gitpod). For me everything still seems to work fine. But it could
How to test
Open a terminal and check everything still works
Follow-ups
Review checklist
Reminder for reviewers