Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not run TerserPlugin in parallel #386

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Do not run TerserPlugin in parallel #386

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions applications/electron/webpack.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
// @ts-check
const configs = require('./gen-webpack.config.js');
const nodeConfig = require('./gen-webpack.node.config.js');
const TerserPlugin = require('terser-webpack-plugin');

/**
* Expose bundled modules on window.theia.moduleName namespace, e.g.
Expand All @@ -15,6 +16,29 @@ configs[0].module.rules.push({
loader: require.resolve('@theia/application-manager/lib/expose-loader')
}); */

/**
* Do no run TerserPlugin with parallel: true
* Each spawned node may take the full memory configured via NODE_OPTIONS / --max_old_space_size
* In total this may lead to OOM issues
*/
if (nodeConfig.config.optimization) {
nodeConfig.config.optimization.minimizer = [
new TerserPlugin({
parallel: false,
exclude: /^(lib|builtins)\//
})
];
}
for (const config of configs) {
config.optimization = {
minimizer: [
new TerserPlugin({
parallel: false
})
]
};
}

module.exports = [
...configs,
nodeConfig.config
Expand Down
Loading