Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Linux MIME types #371

Merged
merged 1 commit into from
Sep 19, 2024
Merged

Add Linux MIME types #371

merged 1 commit into from
Sep 19, 2024

Conversation

Mailaender
Copy link
Contributor

@Mailaender Mailaender commented Jul 6, 2024 •
edited
Loading

This allows right-click open folder with Theia IDE by default on KDE.

jfaltermeier
jfaltermeier reviewed Sep 18, 2024
View reviewed changes
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have one comment about the text/plain type, which would not be a blocker imo.
The inode/directory works as expected.

applications/electron/electron-builder.yml Outdated Show resolved Hide resolved
@Mailaender
Copy link
Contributor Author

I removed it.

jfaltermeier
jfaltermeier approved these changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@jfaltermeier jfaltermeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks I'll go ahead and merge despite the failing "3PP License Check" (internal error) since the licenses/dependencies are unchanged.

@jfaltermeier jfaltermeier merged commit 41075ba into eclipse-theia:master Sep 19, 2024
5 of 6 checks passed
@Mailaender Mailaender deleted the patch-1 branch September 19, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jfaltermeier jfaltermeier jfaltermeier approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Mailaender @jfaltermeier