Update browser.Dockerfile #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Building the browser.Dockerfile fails at line 26 as the .git directory appears missing. With rm -f the build no longer fails.
jfaltermeier
approved these changes
Jul 1, 2024
There was a problem hiding this comment.
Thanks, looks good to me.
The mac os runners on Github seem stuck atm, but the mac build succeeded on the Eclipse CI.
I am not sure why the License Check fails with an internal error, but this PR does not change any dependencies so the licenses are unchanged, so we may ignore this check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building the browser.Dockerfile fails at line 26 as the .git directory appears missing. With rm -f the build no longer fails.
What it does
The -f flag on rm stops the build from failing during build, as the missing .git directory is no longer critical.
How to test
Run docker build . --file browser.Dockerfile
Review checklist
Reminder for reviewers