Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not run TerserPlugin in parallel #386

Merged
merged 1 commit into from
Sep 2, 2024
Merged

Do not run TerserPlugin in parallel #386

merged 1 commit into from
Sep 2, 2024

Conversation

jfaltermeier
Copy link
Contributor

@jfaltermeier jfaltermeier commented Sep 2, 2024

What it does

Update webpack config to not run TerserPlugin in parallel.
Running in parallel may lead to OOM issues on smaller/shared build nodes

The Job that ran out of memory during webpack: https://ci.eclipse.org/theia/job/Theia2/job/master/158/

We had similar issues here: eclipse-cdt-cloud/cdt-cloud-blueprint#91

Contributed on behalf of STMicroelectronics

How to test

Check if build still works

Review checklist

Reminder for reviewers

* especially in production mode this may lead to OOM issues on
smaller/shared build nodes

Contributed on behalf of STMicroelectronics
@jfaltermeier jfaltermeier marked this pull request as ready for review September 2, 2024 10:22
Copy link
Contributor

@sgraband sgraband left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM 👍

@jfaltermeier jfaltermeier merged commit f3e185c into master Sep 2, 2024
6 checks passed
@jfaltermeier jfaltermeier deleted the jf/oom branch September 2, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants