Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(component): Add component page #64

Merged
merged 2 commits into from
Jul 3, 2023

Conversation

tuannn2
Copy link
Contributor

@tuannn2 tuannn2 commented Jun 29, 2023

Issue: #10

Description:

Feature Add Component page

Suggest Reviewer:

@hoangnt2 @heliocastro

@heliocastro heliocastro self-requested a review June 29, 2023 09:36
@tuannn2 tuannn2 force-pushed the release/add_componenet_page branch from 5ac535f to 71e3375 Compare June 29, 2023 10:13
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe would be a good idea some atomic commits, for example per component ?
I added several comments

package.json Show resolved Hide resolved
src/components/AddAdditionalRoles.tsx Show resolved Hide resolved
src/components/AddAdditionalRoles.tsx Outdated Show resolved Hide resolved
src/components/AddAdditionalRoles.tsx Outdated Show resolved Hide resolved
src/components/SearchModerators/ModeratorsTable.tsx Outdated Show resolved Hide resolved
src/components/SearchModerators/ModeratorsDiaglog.tsx Outdated Show resolved Hide resolved
src/components/SelectCountry.tsx Outdated Show resolved Hide resolved
@tuannn2 tuannn2 force-pushed the release/add_componenet_page branch from 71e3375 to e015a56 Compare July 3, 2023 04:08
@tuannn2
Copy link
Contributor Author

tuannn2 commented Jul 3, 2023

Thank you for your reviewing, @heliocastro
I have updated. Please check it!

src/components/AddAdditionalRoles.tsx Outdated Show resolved Hide resolved
src/components/AddKeyValue.tsx Outdated Show resolved Hide resolved
@tuannn2 tuannn2 force-pushed the release/add_componenet_page branch from e015a56 to 30013f2 Compare July 3, 2023 04:57
@tuannn2
Copy link
Contributor Author

tuannn2 commented Jul 3, 2023

Thank you for your reviewing, @hoangnt2
I have updated.

@heliocastro heliocastro self-requested a review July 3, 2023 06:34
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go

@heliocastro heliocastro merged commit 5b697dc into eclipse-sw360:main Jul 3, 2023
2 checks passed
@tienlee tienlee mentioned this pull request Sep 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants