Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Added username and password based basic authentication #286

Closed

Conversation

smrutis1
Copy link
Contributor

@smrutis1 smrutis1 commented Jul 8, 2024

@smrutis1
Copy link
Contributor Author

smrutis1 commented Jul 8, 2024

This is what my .env file look like
image

@ag4ums ag4ums added needs codes review needs codes review needs general test needs general test labels Jul 8, 2024
Copy link
Contributor

@heliocastro heliocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KoukiHama KoukiHama removed the request for review from hoangnt2 July 10, 2024 09:21
@heliocastro heliocastro removed needs codes review needs codes review needs general test needs general test labels Jul 10, 2024
@heliocastro
Copy link
Contributor

@heliocastro
Copy link
Contributor

I cosigned and merged your branch, closing the PR.
@ag4ums Please verify in the future if all your devs are properly set with GPG keys and their git sign in environments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants