Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

N&N for Theme Improvements #200

Merged
merged 4 commits into from
Aug 22, 2024
Merged

Conversation

BeckerWdf
Copy link
Contributor

news/4.33/platform.html Outdated Show resolved Hide resolved
news/4.33/platform.html Show resolved Hide resolved
@BeckerWdf BeckerWdf force-pushed the new_theme branch 2 times, most recently from e4a25df to f21f539 Compare August 20, 2024 12:12
Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this (and in general for all the last minute adjustments!).
I have two suggestions below.

news/4.33/platform.html Outdated Show resolved Hide resolved
news/4.33/platform.html Outdated Show resolved Hide resolved
@BeckerWdf
Copy link
Contributor Author

image

Copy link
Member

@HannesWell HannesWell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thank you!

@HannesWell
Copy link
Member

@BeckerWdf before submission, can you please squash all commits into one?

@BeckerWdf BeckerWdf merged commit ca8515a into eclipse-platform:master Aug 22, 2024
1 check passed
@BeckerWdf BeckerWdf deleted the new_theme branch August 22, 2024 05:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants