Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 2018 deprecated runtime contenttype extension point #1644

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Nov 27, 2024

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

@HannesWell
Copy link
Member

In 2018 we marked this extension point for deletion, lets remove it for 2025-03.

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From afe5f02a7108b4144281850a5d6d9b472a359832 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Wed, 27 Nov 2024 22:40:14 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
index e23c69f6a9..1ef4c9aa7d 100644
--- a/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
+++ b/runtime/bundles/org.eclipse.core.runtime/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
-Bundle-Version: 3.32.0.qualifier
+Bundle-Version: 3.32.100.qualifier
 Bundle-SymbolicName: org.eclipse.core.runtime; singleton:=true
 Bundle-Vendor: %providerName
 Bundle-Activator: org.eclipse.core.internal.runtime.PlatformActivator
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

@vogella
Copy link
Contributor Author

vogella commented Nov 27, 2024

Awesome @HannesWell that works. Thank you for the tip

@vogella
Copy link
Contributor Author

vogella commented Nov 27, 2024

Have you checked if the extension-point is used anywhere in the SDK? I remember that quite a number of extensions for deprecated points exit.

Will do.

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Test Results

 1 674 files   -  81   1 674 suites   - 81   1h 34m 35s ⏱️ + 6m 2s
 4 017 tests  - 153   3 989 ✅  - 159   22 💤 ±0   6 ❌ + 6 
12 648 runs   - 459  12 466 ✅  - 477  164 💤 ±0  18 ❌ +18 

For more details on these failures, see this check.

Results for commit e25e5b0. ± Comparison against base commit 3776c2f.

This pull request removes 153 tests.
AllCompareTests AsyncExecTests ‑ testCancelOnRequeue
AllCompareTests AsyncExecTests ‑ testQueueAdd
AllCompareTests AsyncExecTests ‑ testWorker
AllCompareTests CompareFileRevisionEditorInputTest ‑ testPrepareCompareInputWithNonLocalResourceTypedElements
AllCompareTests CompareUIPluginTest ‑ testFindContentViewerDescriptorForTextType_StreamAccessor
AllCompareTests CompareUIPluginTest ‑ testFindContentViewerDescriptor_TextType_NotStreamAccessor
AllCompareTests CompareUIPluginTest ‑ testFindContentViewerDescriptor_UnknownType
AllCompareTests ContentMergeViewerTest ‑ testFFFX
AllCompareTests ContentMergeViewerTest ‑ testFFTX
AllCompareTests ContentMergeViewerTest ‑ testFFXF
…

♻️ This comment has been updated with latest results.

In 2018 we marked this extension point for deletion, lets remove it for
2025-03.
@vogella vogella force-pushed the delete-deprecated-extension-point branch from 655204f to e25e5b0 Compare November 28, 2024 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants