Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating OpenCloseTest to JUnit5 #2619

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Dec 11, 2024

Adding jupiter API to MANIFEST.MF
Migrating OpenCloseTest to JUnit5

Adding jupiter API to MANIFEST.MF
Migrating OpenCloseTest to JUnit5
@vogella
Copy link
Contributor Author

vogella commented Dec 11, 2024

I assume that the build will fail as I now start to use JUnit5 for the first time in this plug-in @HeikoKlare please remind me what I have to do to make JUnit4 and JUnit5 co-exist.

@vogella vogella marked this pull request as draft December 11, 2024 11:09
@akurtakov
Copy link
Member

Having the test suite JUnit 3.x parts (extends TestCase) being converted to JUnit 4.x first would be nicer as I'm not looking for a mixture of JUnit 3/4/5 in the same test bundle.

Copy link
Contributor

Test Results

 1 818 files   -  3   1 818 suites   - 3   1h 33m 42s ⏱️ - 1m 35s
 7 724 tests  -  5   7 495 ✅  -  5  228 💤 ±0  1 ❌ ±0 
24 333 runs   - 15  23 583 ✅  - 15  749 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 0f444ca. ± Comparison against base commit 4721af7.

This pull request removes 5 tests.
UiTestSuite org.eclipse.ui.tests.stress.OpenCloseTest ‑ testOpenCloseFile
UiTestSuite org.eclipse.ui.tests.stress.OpenCloseTest ‑ testOpenCloseIntro
UiTestSuite org.eclipse.ui.tests.stress.OpenCloseTest ‑ testOpenClosePerspective
UiTestSuite org.eclipse.ui.tests.stress.OpenCloseTest ‑ testOpenCloseView
UiTestSuite org.eclipse.ui.tests.stress.OpenCloseTest ‑ testOpenCloseWorkbenchWindow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants