Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove done() call on SubMonitor in Refactoring #2578

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vogella
Copy link
Contributor

@vogella vogella commented Dec 3, 2024

Copy link
Contributor

github-actions bot commented Dec 3, 2024

Test Results

 1 214 files   -   607   1 214 suites   - 607   1h 12m 51s ⏱️ - 37m 57s
 7 726 tests ±    0   7 495 ✅  -     2  231 💤 +  3  0 ❌  - 1 
16 226 runs   - 8 113  15 713 ✅  - 7 878  513 💤  - 234  0 ❌  - 1 

Results for commit aaddfd6. ± Comparison against base commit 98ff2aa.

This pull request skips 3 tests.
UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

jukzi
jukzi previously requested changes Dec 4, 2024
Copy link
Contributor

@jukzi jukzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The caller Will not expect that the callee invokes done() on the monitor. The caller must either use an SubMonitor (or a similar implementation which does not require done() to be invoked), or it must take responsibility for calling done() on the monitor after the callee has finished.
Reads like this done() is valid

@vogella
Copy link
Contributor Author

vogella commented Dec 4, 2024

The caller Will not expect that the callee invokes done() on the monitor. The caller must either use an SubMonitor (or a similar implementation which does not require done() to be invoked), or it must take responsibility for calling done() on the monitor after the callee has finished. Reads like this done() is valid

See Changes in Eclipse 4.7

@vogella vogella dismissed jukzi’s stale review December 4, 2024 13:38

See 5.3 Changes in Eclipse 4.7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants