Use SubMonintor in FileBufferOperationAction

[vogella]

done() call not necessary here and convert can also show the label and set the number of work unit.

See https://www.eclipse.org/articles/Article-Progress-Monitors/article.html

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From d692bc40b8c85f2304cec95fc7eb76a67b18b9f6 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 3 Dec 2024 13:57:03 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
index 96c4987c88..9a63a5630f 100644
--- a/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.ui.editors/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.ui.editors; singleton:=true
-Bundle-Version: 3.19.0.qualifier
+Bundle-Version: 3.19.100.qualifier
 Bundle-Activator: org.eclipse.ui.internal.editors.text.EditorsPlugin
 Bundle-ActivationPolicy: lazy
 Bundle-Vendor: %providerName
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

[github-actions]

Test Results

0 tests  ±0   0 ✅ ±0   0s ⏱️ ±0s
0 suites ±0   0 💤 ±0 
0 files   ±0   0 ❌ ±0 

Results for commit 30b1302. ± Comparison against base commit 90ae151.

♻️ This comment has been updated with latest results.

[jukzi]

May i ask to add or modify an existing test to actually test the progress using FussyProgressMonitor? I have seen so much things broken by needless conversion to Subprogressmonitor without proper testing.

[vogella]

May i ask to add or modify an existing test to actually test the progress using FussyProgressMonitor? I have seen so much things broken by needless conversion to Subprogressmonitor without proper testing.

Its about removing the unnecessary done call, not about progress reporting.

[jukzi]

The FussyProgressMonitor will check if its ok to remove the done call or not, i.e. if all progress is reported.