Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve UI Indication for Unsaved Changes in Tabs #2568

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

schneidermic0
Copy link

@schneidermic0 schneidermic0 commented Dec 2, 2024

This change enables the indication for unsaved changes in tabs as described in eclipse-platform/eclipse.platform.swt#1632.

This PR depends on eclipse-platform/eclipse.platform.swt#1632 and must not be merged before eclipse-platform/eclipse.platform.swt#1632 is merged.

Tasks

Tabs render dirty parts by showing a `*` in front of the tab name (e.g.,
in front of the file name.

This information is hard to see by developers. This change introduces a
graphical indicator on the close button to highlight dirty (unsaved)
changes.
@schneidermic0
Copy link
Author

Build errors are caused by dependency to eclipse-platform/eclipse.platform.swt#1632

@eclipse-platform-bot
Copy link
Contributor

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch
From 1d2bdec2987831d9f877837a8c13222601314e13 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 2 Dec 2024 20:22:39 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
index cc823104a9..2bef9ec5ed 100644
--- a/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.workbench.renderers.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.workbench.renderers.swt;singleton:=true
-Bundle-Version: 0.16.600.qualifier
+Bundle-Version: 0.16.700.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

Copy link
Contributor

github-actions bot commented Dec 2, 2024

Test Results

0 files   -  1 821  0 suites   - 1 821   0s ⏱️ - 1h 52m 30s
0 tests  -  7 726  0 ✅  -  7 497  0 💤  - 228  0 ❌  - 1 
0 runs   - 24 339  0 ✅  - 23 591  0 💤  - 747  0 ❌  - 1 

Results for commit f13154f. ± Comparison against base commit 6c459cc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants