Remove gradient from placeholder images in JFace

[vogella]

The gradient placeholder is replace with just an empty image.

[github-actions]

Test Results

 1 214 files   -   607   1 214 suites   - 607   1h 17m 39s ⏱️ - 34m 51s
 7 726 tests ±    0   7 495 ✅  -     2  231 💤 +  3  0 ❌  - 1 
16 226 runs   - 8 113  15 713 ✅  - 7 878  513 💤  - 234  0 ❌  - 1 

Results for commit 84394fb. ± Comparison against base commit 6c459cc.

This pull request skips 3 tests.

UiTestSuite org.eclipse.ui.tests.api.ApiTestSuite org.eclipse.ui.tests.api.WorkbenchPluginTest ‑ testGetImageRegistryFromAdditionalDisplay
org.eclipse.jface.text.tests.contentassist.ContextInformationTest ‑ testContextInfo_hide_focusOut
org.eclipse.urischeme.internal.registration.TestUnitWinRegistry ‑ testWinRegistry

♻️ This comment has been updated with latest results.

[vogella]

@HannesWell sorry to ping you again, but why does the version bot not add a commit to update the jface plug-in version in this case?

[BeckerWdf]

See also eclipse-platform/eclipse.platform.images#116

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.jface/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From f9fa250912f50062d2a167a7005513d64f721f69 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Mon, 2 Dec 2024 17:49:04 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/bundles/org.eclipse.jface/META-INF/MANIFEST.MF b/bundles/org.eclipse.jface/META-INF/MANIFEST.MF
index de20b5090a..47bd323cd1 100644
--- a/bundles/org.eclipse.jface/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.jface/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %pluginName
 Bundle-SymbolicName: org.eclipse.jface;singleton:=true
-Bundle-Version: 3.35.100.qualifier
+Bundle-Version: 3.35.200.qualifier
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
 Export-Package: org.eclipse.jface,
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

[BeckerWdf]

Can you please elaborate on this change?
Can you show before and after screenshots?

[merks]

This seems so arbitrary, without justification. What purpose can a bunch of completely transparent images serve?

[vogella]

Can you please elaborate on this change? Can you show before and after screenshots?

Sure, will do, just waiting for our "random" build failures to vanish.

[vogella]

This seems so arbitrary, without justification. What purpose can a bunch of completely transparent images serve?

We replaced a lot of (ugly) gradients in the past with solid colors. If you do not have a gradient in a component, you end up with a solid background color. The common path forward seems to be that gradients are not very modern looking and solid background are nicer. For reference you could compare the old forms styling from older releases (https://eclipse.dev/eclipse/news/4.5/M5/images/dark_theme_old_pde.png) with the latest styling.

[BeckerWdf]

Any news on this?

[vogella]

Build still failing, so no news here