Refresh option not available for some resources that are not closed p…

[DaveCarpeneto]

Refresh option not available for some resources that are not closed projects #2538

Change made since the fix to #1438 unintentionally removed the "refresh" contextual menu for resources that are not projects.

With this change the "refresh" contextual menu is shown if ANY navigator selection is either (A) an open project, or (B) a non-project resource. Put another way: the 'refresh' item is NOT shown if ALL selections are closed projects.

Fixes #2538

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 03d2a18e69bdab3cc1b7860fe57db0c94a4dbf2f Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 3 Dec 2024 20:04:53 +0000
Subject: [PATCH] Version bump(s) for 4.35 stream


diff --git a/tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF b/tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF
index 30b05fff0f..438a303964 100644
--- a/tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF
+++ b/tests/org.eclipse.ui.tests.navigator/META-INF/MANIFEST.MF
@@ -2,7 +2,7 @@ Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-Name: %bundlename
 Bundle-SymbolicName: org.eclipse.ui.tests.navigator;singleton:=true
-Bundle-Version: 3.7.600.qualifier
+Bundle-Version: 3.7.700.qualifier
 Bundle-Localization: plugin
 Require-Bundle: org.eclipse.core.resources,
  org.eclipse.core.runtime;bundle-version="[3.29.0,4.0.0)",
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

[DaveCarpeneto]

This replaces #2539

@jukzi : apologies for the second pull request; I'm new to GitHub. For reference, the changes requested were:

• please use for-each loop instead -> done
• please add explanation why projects.size() < selection.size() is used here. That is not self-explaining / maybe introduce a variable like selectionContainsNonProject -> done
• The commit message does not follow our best practice -> changed

[github-actions]

Test Results

 1 821 files  ± 0   1 821 suites  ±0   1h 59m 48s ⏱️ + 9m 0s
 7 731 tests + 5   7 502 ✅ + 5  228 💤 ±0  1 ❌ ±0 
24 354 runs  +15  23 606 ✅ +15  747 💤 ±0  1 ❌ ±0 

For more details on these failures, see this check.

Results for commit 76d98bb. ± Comparison against base commit 98ff2aa.

♻️ This comment has been updated with latest results.

[jukzi]

apologies for the second pull request;

no worries. The jenkins build failed with "An unexpected error occurred while launching the test runtime (process returned error code 13)". I do not know why i restarted the job. We need a green result before it could be merged.

[jukzi]

Does not look bad overall. Could you please try to add a junit test for it?

[DaveCarpeneto]

Does not look bad overall. Could you please try to add a junit test for it?

Added in today's commit. Please let me know if anything looks incorrect (I used other unit tests in this section for reference, but since I couldn't find a guide as to what is expected (other than https://github.com/eclipse-platform/.github/blob/main/CONTRIBUTING.md 's missive that tests should run and pass (which these do)).

[DaveCarpeneto]

Hi @jukzi - anything else needed on this pull request from my end? I don't think I see anything, but I'm still very new to github :-)

[jukzi]

This repo does not allow merge commits. Please squash all changes into a single commit and rebase on head. Once the automated checks are successful someone might take the time to test your change manually.

[DaveCarpeneto]

Please squash all changes into a single commit

To reduce mess / risk I've simply created a new pull request with a single commit #2601