Create Color Definition for Reuse

[BeckerWdf]

Instead of writing the same RBG color codes over and over again in various places in the CSS files only do it once.
Define a new color and re-use that color definition at all other locations. This also adds a semantic name to the color code.

Unfortunately color definitions cannot refer to other color definitions. So at some places we still have to provides the color code. These places are marked with a comment.

The new defined color is now also visible in the "Colors and Fonts" preference page. I am unsure if this is something we want. If users change this this does not work 100% because of the limitation above.

[BeckerWdf]

I only tested on macOS.

[BeckerWdf]

@mvm-sap, @sratz what do you think?

[github-actions]

Test Results

 1 214 files  ±0   1 214 suites  ±0   1h 14m 53s ⏱️ + 1m 57s
 7 729 tests ±0   7 494 ✅  - 1  233 💤 ±0  2 ❌ +1 
16 232 runs  ±0  15 715 ✅  - 1  515 💤 ±0  2 ❌ +1 

For more details on these failures, see this check.

Results for commit f59a57c. ± Comparison against base commit 8bd169c.

♻️ This comment has been updated with latest results.

[BeckerWdf]

The new defined color is now also visible in the "Colors and Fonts" preference page. I am unsure if this is something we want. If users change this this does not work 100% because of the limitation above.

With 845377a this issue is fixed.

[eclipse-platform-bot]

This pull request changes some projects for the first time in this development cycle.
Therefore the following files need a version increment:

bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF

An additional commit containing all the necessary changes was pushed to the top of this PR's branch. To obtain these changes (for example if you want to push more changes) either fetch from your fork or apply the git patch.

Git patch

From 539b2270bdd6afe6a47f90f107b2d14cf738df63 Mon Sep 17 00:00:00 2001
From: Eclipse Platform Bot <[email protected]>
Date: Tue, 29 Oct 2024 09:35:16 +0000
Subject: [PATCH] Version bump(s) for 4.34 stream


diff --git a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
index a10944e052..b6e6c4e55d 100644
--- a/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
+++ b/bundles/org.eclipse.e4.ui.css.swt/META-INF/MANIFEST.MF
@@ -1,7 +1,7 @@
 Manifest-Version: 1.0
 Bundle-ManifestVersion: 2
 Bundle-SymbolicName: org.eclipse.e4.ui.css.swt;singleton:=true
-Bundle-Version: 0.15.400.qualifier
+Bundle-Version: 0.15.500.qualifier
 Bundle-Name: %pluginName
 Bundle-Vendor: %providerName
 Bundle-Localization: plugin
-- 
2.47.0

Further information are available in Common Build Issues - Missing version increments.

[sratz]

Are we somehow committing to the id of the definition org-eclipse-ui-workbench-SECONDARY_BACKGROUND and have to keep it stable?

I guess with the latest hidden flag, we can consider this ID to be purely internal and should be able to rename this?

[BeckerWdf]

Are we somehow committing to the id of the definition org-eclipse-ui-workbench-SECONDARY_BACKGROUND and have to keep it stable?

I guess with the latest hidden flag, we can consider this ID to be purely internal and should be able to rename this?

I would say we can consider it internal as it only appears in the CSS files. Anyway: Do you have a better name?

[sratz]

I would say we can consider it internal as it only appears in the CSS files.

👍

Anyway: Do you have a better name?

No, hence the question 😉

[vogella]

I think it is great to allow the user to change the default colour. I think it should be relatively easy to implement that colors refer to others in CSS. What exactly is the requirement here @BeckerWdf ?

[BeckerWdf]

think it should be relatively easy to implement that colors refer to others in CSS. What exactly is the requirement here?

What I want to do is this:

ColorDefinition#org-eclipse-ui-workbench-ACTIVE_UNSELECTED_TABS_COLOR_START {
	color: '#org-eclipse-ui-workbench-SECONDARY_BACKGROUND';
}

instead of:

ColorDefinition#org-eclipse-ui-workbench-ACTIVE_UNSELECTED_TABS_COLOR_START {
	color: #F8F8F8;
}

@vogella: Would be great if you could help here. Feel free to push a separate PR / an additional commit to this PR

[BeckerWdf]

This PR needs to be reworked after #2549 is merged.

[BeckerWdf]

pr-head fails with:

12:20:08.576 [ERROR] Failed to execute goal org.eclipse.tycho.extras:tycho-p2-extras-plugin:4.0.10:compare-version-with-baselines (compare-attached-artifacts-with-release) on project org.eclipse.jface: Baseline and reactor have the same fully qualified version, but different content

@HannesWell: What's the issue here?