Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAC] - Light(Preview) theme - Fix for missing alternate row colors for Tree #2404

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Oct 15, 2024

Tree Viewers had alternate row colors if they had coloumns, in Light Theme. This was missing in Light(Preview) theme. This has been fixed with this change by making swt-lines-visible (Tree Property) to true.
Please refer #2395

@@ -126,6 +125,11 @@ CTabFolder Canvas {
background-color: #f8f8f8;
}

.View Composite Tree{
background-color: #f8f8f8;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on macOS.
Zebra-Lines are not visible because of this line. If this is removed. Zebar-Lines are visible.

@@ -126,6 +125,11 @@ CTabFolder Canvas {
background-color: #f8f8f8;
}

.View Composite Tree{
background-color: #f8f8f8;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
background-color: #f8f8f8;

Copy link
Contributor

github-actions bot commented Oct 15, 2024

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 39m 20s ⏱️ + 3m 57s
 7 709 tests ±0   7 479 ✅  - 2  228 💤 ±0  1 ❌ +1  1 🔥 +1 
24 288 runs  ±0  23 539 ✅  - 2  747 💤 ±0  1 ❌ +1  1 🔥 +1 

For more details on these failures and errors, see this check.

Results for commit 28b2a1f. ± Comparison against base commit d6a50a4.

♻️ This comment has been updated with latest results.

@mvm-sap mvm-sap force-pushed the Fix_tree_viewer_alternate_colors_issue branch from 946ba25 to 00e7413 Compare October 15, 2024 14:40
Copy link
Contributor

@BeckerWdf BeckerWdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@BeckerWdf
Copy link
Contributor

with this PR:
Screenshot 2024-10-15 at 16 45 24

before:
Screenshot 2024-10-15 at 16 46 48

@mvm-sap
Copy link
Contributor Author

mvm-sap commented Oct 16, 2024

with this PR: Screenshot 2024-10-15 at 16 45 24

before: Screenshot 2024-10-15 at 16 46 48

In after image, Project Explorer and Outline view have white background

@mvm-sap mvm-sap force-pushed the Fix_tree_viewer_alternate_colors_issue branch from 00e7413 to 28b2a1f Compare October 16, 2024 06:46
@BeckerWdf
Copy link
Contributor

In after image, Project Explorer and Outline view have white background

You are right. So they requirement would be: Show the zebra-lines in Trees but only when the tree has more then one column. Correct?

@mvm-sap
Copy link
Contributor Author

mvm-sap commented Oct 16, 2024

In after image, Project Explorer and Outline view have white background

You are right. So they requirement would be: Show the zebra-lines in Trees but only when the tree has more then one column. Correct?

Yes

@Phillipus
Copy link
Contributor

So they requirement would be: Show the zebra-lines in Trees but only when the tree has more then one column. Correct?

Actually zebra lines are only visible when Tree#setLinesVisible(true)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants