make "Text editor code mining color" configurable in preferences #2400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This was already requested a while ago when code minings got introduced, but never implemented. So it's a good thing to add it now. |
Test Results 1 818 files ±0 1 818 suites ±0 1h 32m 51s ⏱️ - 2m 32s For more details on these failures, see this check. Results for commit 8488e22. ± Comparison against base commit d6a50a4. ♻️ This comment has been updated with latest results. |
|
And I found the link! https://bugs.eclipse.org/bugs/show_bug.cgi?id=541406 |
BeckerWdf
requested changes
Oct 14, 2024
...ui.editors/src/org/eclipse/ui/texteditor/AbstractDecoratedTextEditorPreferenceConstants.java
Show resolved
Hide resolved
...pse.ui.workbench.texteditor/src/org/eclipse/ui/texteditor/SourceViewerDecorationSupport.java
Show resolved
Hide resolved
BeckerWdf
force-pushed
the
code_mining_color
branch
from
ffb35ae
to
3947cd5
Compare
tobiasmelcher
force-pushed
the
code_mining_color
branch
2 times, most recently
from
1be1284
to
6df7f78
Compare
Victko
approved these changes
Oct 16, 2024
BeckerWdf
requested changes
Oct 16, 2024
|
Before and After: |
|
Color Contrast in Dark Mode increased from 3.38:1 to 4.81:1 See: And one can still distinguish with the "normal" text editor font.. |
BeckerWdf
approved these changes
Oct 16, 2024
|
Maybe off-topic, but I really wish I could also separately change the font size of code minings |
|
why does build-pr fail? |
|
I would try to rebase the branch... |
I propose to add this in an additional PR. |
introduce a new entry in preference page "General"->"Appearance"->"Colors and Fonts" so that code mining color can be configured by the end user Introduce a slightly brighter default color for code minings in the dark theme.
Remove remainders from an internal test.
BeckerWdf
force-pushed
the
code_mining_color
branch
from
dcb54d7
to
8488e22
Compare
|
failing test on macOS is documented already in #370 |
BeckerWdf
added a commit
to BeckerWdf/www.eclipse.org-eclipse
that referenced
this pull request
Oct 17, 2024
BeckerWdf
added a commit
to BeckerWdf/www.eclipse.org-eclipse
that referenced
this pull request
Oct 17, 2024
BeckerWdf
added a commit
to eclipse-platform/www.eclipse.org-eclipse
that referenced
this pull request
Oct 17, 2024
|
I am facing an issue with |
|
sorry, my fault. #2415 should fix the null pointer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
introduce a new entry in preference page "General"->"Appearance"->"Colors and Fonts" so that code mining color can be configured by the end user
Introduce a slightly brighter default color for code minings in the dark theme.
What do you think? Does it make sense to allow users to configure the code mining color? Currently SWT.COLOR_DARK_GRAY is used in all themes wich might be a problem in the dark theme.