Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase InternalDialog width hint from 50 characters to 70 characters #2386

Merged

Conversation

merks
Copy link
Contributor

@merks merks commented Oct 11, 2024

At 50 characters, the dialog almost never is able to display a message without wrapping:

image

Even at 70 characters it's still small but at least there is a better chance that the text will fit:

image

@laeubi
Copy link
Contributor

laeubi commented Oct 11, 2024

@merks not sure if you want to even more improve the situation, I think it would be good to fetch the monitor for the shell then get the size and use a percentage based approach (maybe with a min + max value) instead of a fixed value maybe.

@merks
Copy link
Contributor Author

merks commented Oct 11, 2024

I'm not sure I want to go down that rabbit hole. 😜

Search the regex convertWidthInCharsToPixels\([0-9] in the SDK workspace and find the 250+ matches:

image

The design intent in general is to display the specified/expected number of average characters which of course scales properly depending on fonts and resolutions.

If we want to make improvements, this seldom-seen dialog is probably not the most important place to focus such improvements, and we'd probably want provide support for such improvements in a central location, rather than distributed across the framework.

Copy link
Contributor

Test Results

 1 818 files  ±0   1 818 suites  ±0   1h 30m 58s ⏱️ - 2m 8s
 7 708 tests ±0   7 478 ✅  - 1  228 💤 ±0  2 ❌ +1 
24 285 runs  ±0  23 536 ✅  - 1  747 💤 ±0  2 ❌ +1 

For more details on these failures, see this check.

Results for commit 40603fc. ± Comparison against base commit 4e0740d.

@merks merks merged commit 6d7fa39 into eclipse-platform:master Oct 11, 2024
15 of 17 checks passed
@merks merks deleted the pr-expand-internal-dialog-width branch October 11, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants