Find/replace overlay: improve replace toggle button appearance

[HeikoKlare]

The button to toggle whether the replace bar in a find/replace overlay is shown currently appears to be a rather heavyweight button with a border. With this change, the button is replace with a lightweight toolbar item like used for all other buttons in the overlay. This improves the appearance as well as the implementation as the same implementation patterns can now be applied to all buttons in the overlay.

This is also a preparatory change for #2254 as with that change optmizing the appearance of the button would otherwise become difficult.

How it looks

Windows

Before:

After:

MacOS

Before:

After:

Linux

Before:

After:

[HeikoKlare]

@Wittmaxi what do you think? Is there anything speaking against this change, maybe any reason why this was not the solution in the beginning?

[github-actions]

Test Results

 1 815 files   1 815 suites   1h 34m 18s ⏱️
 7 702 tests  7 474 ✅ 228 💤 0 ❌
24 267 runs  23 520 ✅ 747 💤 0 ❌

Results for commit 21c0c67.

♻️ This comment has been updated with latest results.

[Wittmaxi]

I think this change looks good, improves code quality and makes maintenance easier in the future. Once the tests go green, this can be merged IMHO (is there a reason this is still a draft?)

Slight caveat: this outline doesn't really feel to me like it belongs there.

[HeikoKlare]

Slight caveat: this outline doesn't really feel to me like it belongs there.

Do you mean the missing margin to the right or the small size of the button in general? The former is fixed in the recent push. The latter is something I do not have a solution for since toolbars / toolbar items doe seems to be (easily) sizable.

[HeikoKlare]

Let's give this a try.