Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FindNextAction] Introduce unit tests #2330

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Wittmaxi
Copy link
Contributor

@Wittmaxi Wittmaxi commented Sep 26, 2024

Introduces unit tests for the FindNextAction.
I don't achieve 100% test coverage, but I test for the most important parts. Appart from the "naive" functionality, in particular I test for:

  1. search options are taken into account
  2. the search history is honored
  3. whole - word search is only performed if the selection is a word
  4. RegExes are correctly escaped

Copy link
Contributor

github-actions bot commented Sep 26, 2024

Test Results

 1 818 files   1 818 suites   1h 32m 18s ⏱️
 7 719 tests  7 491 ✅ 228 💤 0 ❌
24 318 runs  23 571 ✅ 747 💤 0 ❌

Results for commit d3947bc.

♻️ This comment has been updated with latest results.

@Wittmaxi Wittmaxi marked this pull request as draft September 27, 2024 10:23
@Wittmaxi Wittmaxi marked this pull request as ready for review September 27, 2024 14:34
@Wittmaxi
Copy link
Contributor Author

The test is now in the editors.test package. Reason is that I need to start a whole editor in order to test the FindNextAction using IDE.openEditor. Depending on IDE in the workbench.editors package is problematic and such @HeikoKlare and I convened on moving the test to a more sensible place.

Introduces unit tests for the FindNextAction.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant