Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding hover indicator for unselected tabs #2130

Merged
merged 2 commits into from
Jul 29, 2024

Conversation

mvm-sap
Copy link
Contributor

@mvm-sap mvm-sap commented Jul 25, 2024

Hover indicators are included in both Dark and Light theme for unselected tabs in views and editors.
Light theme,
Editor tab's hover color is set to white
View tab's hover color is set to darker grey

Dark Theme,
Both Editor and View tab's hover color is set to darker black

Please find the details of this issue reported in #2114

Copy link
Contributor

github-actions bot commented Jul 25, 2024

Test Results

 1 815 files  +  605   1 815 suites  +605   1h 32m 1s ⏱️ + 39m 2s
 7 684 tests ±    0   7 455 ✅  -     1  228 💤 ±  0  1 ❌ +1 
24 213 runs  +8 071  23 463 ✅ +7 790  749 💤 +280  1 ❌ +1 

For more details on these failures, see this check.

Results for commit ce7a011. ± Comparison against base commit 944c8db.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great on Windows. I had no chance to test on MacOS yet.

Copy link
Contributor

@HeikoKlare HeikoKlare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also looks good on MacOS. If no one objects, I would like to merge this until end of today to have some hovering indicator again.

@laeubi
Copy link
Contributor

laeubi commented Jul 29, 2024

For visual changes it is always good to include before/after in the PR so it is easier for those that don't have that specific OS at hand :-)

Also I find it easier for reviewers as one then can directly comment on the provided screenshot.

@HeikoKlare
Copy link
Contributor

HeikoKlare commented Jul 29, 2024

For visual changes it is always good to include before/after in the PR so it is easier for those that don't have that specific OS at hand :-)

Also I find it easier for reviewers as one then can directly comment on the provided screenshot.

Fully agree. @mvm-sap, it would be great if you could share before/after screenshots already when opening the PR.

For this one, since I have tested the change anyway, here are some screenshots showing what happens when hovering over the "Progress" view tab (in the bottom view stack):

Windows (light)

Before

image

After

image

Windows (dark)

Before

image

After

image

MacOS

Same as on Windows, thus only providing dark mode screenshots

Before

image

After

image

@HeikoKlare
Copy link
Contributor

Failing test is unrelated and already documented: #294

@HeikoKlare HeikoKlare merged commit 1356bb3 into eclipse-platform:master Jul 29, 2024
14 of 16 checks passed
@mvm-sap mvm-sap deleted the Adding_Hover_Indicator branch July 30, 2024 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants