Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand Bar is not scaled during DPI change #1528

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ShahzaibIbrahim
Copy link
Contributor

@ShahzaibIbrahim ShahzaibIbrahim commented Oct 10, 2024

When moving from one zoom level monitor to another zoom level (no matter what %), The expanded items and texts are not drawn at correct coordinates.

HOW TO TEST

  • Run the ControlExample with the following VM Arguments
-Dswt.autoScale=quarter
-Dswt.autoScale.updateOnRuntime=true
  • Switch to the tab "Expand Items"
  • Move the window from 200 to 100 zoom level monitor (Producible in any combination of zoom levels)
  • See if the "expanded" items are aligned to correct coordinates

SCREENSHOTS

Before Fix:
image

After Fix:
image

Requires

Contributes to #62 and #127

Copy link
Contributor

github-actions bot commented Oct 10, 2024

Test Results

   480 files   -  6     480 suites   - 6   9m 9s ⏱️ + 1m 53s
 4 105 tests  - 54   3 711 ✅  -   440   4 💤  -  4  0 ❌ ±0    390 🔥 +  390 
16 335 runs   - 55  14 688 ✅  - 1 610  70 💤  - 22  0 ❌ ±0  1 577 🔥 +1 577 

For more details on these errors, see this check.

Results for commit c9910b8. ± Comparison against base commit 5dd0c28.

This pull request removes 54 tests.
org.eclipse.swt.graphics.ImageWin32Tests ‑ testImageShouldHaveDimesionAsPerZoomLevel
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_dollarSign
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_emptyString
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_letterA
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicASCII_letters
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16LE_null
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_AsciiLetters
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_Asciiletter
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_LotsOfLetters
org.eclipse.swt.tests.gtk.Test_GtkConverter ‑ test_HeuristicUTF16_letter
…

♻️ This comment has been updated with latest results.

When adding image larger than the header size in expand bar, it was
drawn outside of the bar on the top. This was due to wrong calculation
and mixing of points and pixels
When moving from one zoom level monitor to another zoom level (no matter
what %), The images, expanded items and texts are not drawn at correct
coordinates.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant