Translate points in display coordinate space gap #1524
Conversation
amartya4256
force-pushed
the
shell_repositioning_fix
branch
from
aceb68c
to
43f71a8
Compare
| @@ -1586,7 +1586,8 @@ public void setLocation(Point location) { | |||
|
|
|||
| @Override | |||
| public void setLocation(int x, int y) { | |||
| Point location = display.translateLocationInPixelsInDisplayCoordinateSystem(x, y); | |||
| Point translatedPoint = display.translatePointIfInDisplayCoordinateGap(x, y); | |||
There was a problem hiding this comment.
Isn't this something that should be hidden in the Display class, i.e., performed implicitly when calling translateLocationInPixelsInDisplayCoordinateSystem? Otherwise consumers of the display coordinate system need to know about this potential gap and handle it manually instead of having the display class guarantee the calculation of valid coordinates.
There was a problem hiding this comment.
yeah makes sense. I have moved it inside and also added the translation to a all the places (like map) where it was relevant.
| private Monitor getContainingMonitor(int x, int y) { | ||
| return getContainingMonitorOptional(x, y).orElse(getPrimaryMonitor()); | ||
| } |
There was a problem hiding this comment.
getContainingMonitorOptional() is not that self explaining and the distinction to getContainingMonitor() is not that clear, as both sound similar (except for the "optional") but have different semants: the latter will never return null (or empty) but return the primary monitor instead.
So maybe better call these methods getContainingMonitor (returning Optional<Monitor>) and getContainingOrPrimaryMonitor() or the like?
There was a problem hiding this comment.
Alright I have renamed them. Also for while searching in pixels
amartya4256
force-pushed
the
shell_repositioning_fix
branch
from
43f71a8
to
9c0c469
Compare
This contribution fixes the current behaviour of the display coordinate system of eclipse where a point can be manually set to somewhere in the gap between the 2 monitor in the coordinate space (in the points system). This fix translates those points to inside the scaled down space of a monitor providing it the right coordinates in the display coordinate space. contributes to eclipse-platform#62 and eclipse-platform#127
amartya4256
force-pushed
the
shell_repositioning_fix
branch
from
9c0c469
to
8a157cb
Compare
This contribution fixes the current behaviour of the display coordinate system of eclipse where a point can be manually set to somewhere in the gap between the 2 monitor in the coordinate space (in the points system). This fix translates those points to inside the scaled down space of a monitor providing it the right coordinates in the display coordinate space.
e.g.:
If the client sets a shell's location like:
It would be trasnlated to the proper display coordinate space so that it's scaled in the right way.
contributes to #62 and #127