Refactor Image for storing ImageMetadata #1496
Open
+421
−448
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amartya4256
force-pushed
the
imageMetadata
branch
from
68e8193
to
597c46d
Compare
amartya4256
force-pushed
the
imageMetadata
branch
from
597c46d
to
9acf71a
Compare
amartya4256
force-pushed
the
imageMetadata
branch
2 times, most recently
from
3832a24
to
e353b1a
Compare
akoch-yatta
reviewed
Oct 9, 2024
| return image; | ||
| } | ||
|
|
||
| class ImageMetadata { |
There was a problem hiding this comment.
As we are moving logic into this class now, I would probably renamed it as it is more than data now, something like ImageHandle? And it can be private, can't it?
There was a problem hiding this comment.
How About ImageHandleProvider, since handle is an interior member of it?
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
| @@ -2312,6 +1979,7 @@ public void setBackground(Color color) { | |||
|
|
|||
| /* Get the HDC for the device */ | |||
| long hDC = device.internal_new_GC(null); | |||
| long handle = win32_getHandle(this, getZoom()); | |||
There was a problem hiding this comment.
Hmm, why using this handle? Shouldn't that be applied to all handles?
There was a problem hiding this comment.
Hmm. Earlier, it was just done by the handle. But you are right. It means it was a wrong implementation already.
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
bundles/org.eclipse.swt/Eclipse SWT/win32/org/eclipse/swt/graphics/Image.java
Outdated
Show resolved
Hide resolved
amartya4256
force-pushed
the
imageMetadata
branch
2 times, most recently
from
a6b2e33
to
8067b98
Compare
This contribution encapsulates the metadata of the image in an innerclass ImageHandle which is used to create a hashmap of zoom level to imageHandle object inside an image object, making it straight forward to obtain any metadata information from an image for a zoom level. contributes to eclipse-platform#62 and eclipse-platform#127
amartya4256
force-pushed
the
imageMetadata
branch
from
8067b98
to
6225eae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contributes to the refactoring of Image class for win32. The goal is to encapsulate the metadata in ImageMeadata class and store imageMetadata for each zoom level for every image instead of zoom level to handle. This way we obtain the imagedata for every image at different zoom by calling the metadata object for that zoom level.
contributes to #62 and #127