Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[fix]Use correct DPIUtil call for pixel conversion #1435

Merged
merged 1 commit into from
Sep 4, 2024

Conversation

akoch-yatta
Copy link
Contributor

This commit fixes an issue, where a call to DPIUtil was scaling down from points to pixels instead of scaling down

Fixes #1434

Copy link
Contributor

github-actions bot commented Sep 2, 2024

Test Results

   486 files  ±0     486 suites  ±0   8m 25s ⏱️ + 1m 41s
 4 151 tests ±0   4 143 ✅ ±0   8 💤 ±0  0 ❌ ±0 
16 358 runs  ±0  16 266 ✅ ±0  92 💤 ±0  0 ❌ ±0 

Results for commit 4a47f62. ± Comparison against base commit e44cfc9.

♻️ This comment has been updated with latest results.

@merks
Copy link
Contributor

merks commented Sep 2, 2024

I think this calls for a respin if it all possible.

@MohananRahul

Is a respin possible given the current state of the builds and the git repositories?

This commit fixes an issue, where a call to DPIUtil was scaling down from points to pixels instead of scaling down

Fixes eclipse-platform#1434
@HeikoKlare
Copy link
Contributor

This needs to be merged to be in sync with current release branch (as the change has already been merged into that branch #1437). The failing checks are unrelated to this change, e.g.:

[API ERROR] File MANIFEST.MF at line 6: The minor version should be incremented in version 3.127.100, since execution environments have been changed since version 3.127.0 (location: /home/jenkins/agent/workspace/eclipse.platform.swt_PR-1435/eclipse.platform.swt/binaries/org.eclipse.swt.gtk.linux.x86_64/META-INF/MANIFEST.MF)

Should we merge this despite those warnings in order to make the master branch up to date and address potential unrelated issue separates/afterwards, @akurtakov?

@iloveeclipse
Copy link
Member

The failing checks are unrelated to this change

eclipse-pde/eclipse.pde#1386

@akurtakov
Copy link
Member

Merging as this is already in the 4.33 branch and should have been merged to master first.

@akurtakov akurtakov merged commit 482c7ca into eclipse-platform:master Sep 4, 2024
11 of 14 checks passed
@akoch-yatta akoch-yatta deleted the fix-for-1434 branch September 13, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

JavaDoc hover in java editor looks clipped on HiDPI screens
5 participants