Enable License Check for PDE #982
Conversation
|
/request-license-review |
|
that breaks all builds now |
Yep... Please fix or revert. |
|
We ware await the addition of a GITLAB_API_TOKEN for this organization by the EF-infra team: With that we can request the license vetting of the offending projects. |
|
/request-license-review |
Workflow run (with attached summary files): |
It does NOT break the build because it is not even part of the build. It adds a new check that currently fails because some unvetted artifacts have recently slipped in and that the purpose of this check, to fail so such things did not happen unnoticed. So can we please calm down a bit instead and try to understand why things happen, if anyone is that concerned we can of course fall back to manually checks and creating CQs by hand. |
|
@laeubi : the problem I see is that adding actions that are known to fail distracts everyone for no obvious reason. With every new action added that fails by default everyone learns to ignore github action errors and keep ignoring them in the future. This is https://wiki.c2.com/?FixBrokenWindows in pure form. So we would be happy to see more checks and we value your work, but new checks should be introduced in a way that makes everyone happy. |
|
In this case the choices are:
As 3) is not an option and we can not fix 1) without 2) what we have here is the best forward looking path. |
|
One can read #954 (comment) for the detailed analysis and the request for exactly this one. |
|
Work towards fixing the licensecheck is ongoing in #983 . I am not aware of any other way to have this fixed without suffering short term. |
|
i don't want to read through all the history, can you please summarize why such a change has to be submitted? As far as i understand such checks can also be used with not-submitted PRs, as each PR uses the workflows it submits. |
|
@jukzi https://docs.github.com/en/actions/using-workflows/about-workflows#about-workflows : A PR is not checked in thus workflow in it will not be executed. |
Some action require elevated permissions and can not run as part of a PR, so there is not much of an option, beside that the workflow fails because something is wrong in PDE repository not because the check itself is failing.
No this is maybe ignorance in pure form, please don't blame that on making things VISIBLE, the window is already BROKEN but no one has noticed it yet so please don't start this fruitless discussion again. There is no single line in the committer handbook that says one can ignore failures just because it annoyed anyone in the past.
Please read the committer handbook about IP due diligence, if you feel that we should enforce each and every contribution to be checked by a committer manually then "we" don't need it, if we want to benefit from automatic checks and automatic request "we" need it. |
looks like a PR is treated to be checked in, see example |
|
Because it already is as can be seen at https://github.com/eclipse-pde/eclipse.pde/blob/master/.github/workflows/licensecheck.yml . If there is no such workflow file in the repo it would not be executed. |
thats simply not true - you can see that "call-license-check / check-licenses" in this(982) PR workflow was executed before it was checked in
the same was true when i added codeQL |
|
The requirement seems to be specific to (parts?) of this workflow eclipse-jdtls/eclipse.jdt.ls#2966 (comment) |
Not everything is always that simple, if you have write access to the repository and the check does trigger on PR it will be executed. The Nerveless the check on PR fails because something is WRONG in PDE that got unnoticed and it should fail! So exactly that happens here, we noticed a license problem, I added a check and I want it to show that problem unless we where able to fix it so it never happens again in the future. |
FYI @akurtakov @merks @HannesWell