Remove wrong validation error about forbidden import of java.* packages #706
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HannesWell
force-pushed
the
removeJavaImportError
branch
from
4e819ea
to
2509910
Compare
java.* packages are not forbidden to import (with modular JDKs one is even encouraged to list java.* packages). Even though this error only showed up if any imported package could not be resolved, but since it is (now) perfectly fine to import them as well, there should not be a special error message for that case. This could even cause a false positive if another package is not resolved.
HannesWell
force-pushed
the
removeJavaImportError
branch
from
2509910
to
da1488e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
java.* packages are not forbidden to import (with modular JDKs one is even encouraged to list java.* packages).
Even though this error only showed up if any imported package could not be resolved, but since it is (now) perfectly fine to import them as well, there should not be a special error message for that case. This could even cause a false positive if another package is not resolved.