Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhance computation of system-package provided by a ExecutionEnvironment #693

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Enhance computation of system-package provided by a ExecutionEnvironment #693

merged 1 commit into from
Aug 12, 2023

Commits on Aug 12, 2023

  1. Enhance computation of system-package provided by a ExecutionEnvironment 

    - In the Product or OSGi-app launch validation only consider EE of the
VM that will run the app, match the later runtime-behavior
- For the PDEState the EE's system-package is computed with the
following distinction:
  - for a EE that corresponds to a Java-9 or higher release, get the
  'best matching' VMInstall and query the system-packages for the EE's
  java release version (which is possible for modular JVMs)
  - for a Java-8 or lower release check if there is a VMInstall
  selected/strictly compatible to that version and query the
  system-packages from that VM (i.e. its rt.jar and other libraries)
  - if there is no VMInstall for a for a Java-8 or lower release,
  combine the hard-coded list of 'java.*' packages with the set of
  non-java packages provided by the default VMInstall of the workspace.
  The default VMInstall of the WS is at the same time the JVM selected
  in the active target definition (which sets its selection as WS
  default upon loading).
  - In general the available system-packages are only really known at
  runtime. Therefore at any other time, e.g. in the workspace, one can
  only guess/assume what packages are available and the implemented
  algorithm seems to be the best trade-off between probable accuracy,
  convenience and the possibility to let the user control the result.

- Listen to changes of available VMInstalls and ExecutionEnvironment
defaults. Re-read them on changes and re-resolve the PDE-State again
with a subsequent re-validation of all Plugin projects.
- Adapt existing test-cases that expected some packages to be reported
as present although were not.

Fixes eclipse-pde#429
    @HannesWell
    HannesWell committed Aug 12, 2023
    Configuration menu
    Copy the full SHA
    b84ab4f View commit details
    Browse the repository at this point in the history